This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Fix supershell position bug #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 3, 2019
|
I can't run the validator against sbt/sbt#5025 but it definitely compiles and runs. |
The previous implementation of supershell log line interlacing with regular line interlacing relied on state in a global object. A somewhat better approach is for each appender to hold a reference to a state object. Every time tasks run, new appenders are created, so the state should always reflect the current progress state.
|
Oh, shoot. I force pushed a small fix to remove an extraneous comment. It might have broken the validation. |
|
Re-running dbuild. |
|
FWIW, this looks really good in my local testing. |
|
I'm going to bake it myself locally to check. |
|
Cool. The more eyes, the better. |
|
Tested it using Guardian frontend and akka and both look good. |
eed3si9n
approved these changes
Sep 3, 2019
|
I guess we should wait till Dbuild returns. |
This comment has been minimized.
This comment has been minimized.
|
The only error is |
|
Awesome. I also just finished verifying on my windows and linux vms. Everything looked good (though that's relative on my windows vm which has an extremely sluggish terminal). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of supershell log line interlacing with
regular line interlacing relied on state in a global object. A somewhat
better approach is for each appender to hold a reference to a state
object. Every time tasks run, new appenders are created, so the state
should always reflect the current progress state.