Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of Lightbend support, switch to Plausible analytics #1145

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Jun 20, 2023

image

image

@julienrf
Copy link
Contributor Author

I noticed that the API documentation was not built. I guess it is produced separately?

}
</script>
<!-- OneTrust Cookies Consent Notice (Production Standard, scala-sbt.org, en-GB) end -->
<script defer data-domain="scala-sbt.org" src="https://plausible.scala-lang.org/js/script.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain what this does please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes the banner “This site uses cookies to offer you a better browsing experience…”, and loads the Plausible analytics scripts hosted on the scala-lang.org servers. Plausible is an analytics platform that does not use cookies. Maybe cookies are used by another component of the website?

@eed3si9n
Copy link
Member

I noticed that the API documentation was not built. I guess it is produced separately?

Yes, it's built using sbt/sbt's special branch and sbt-unidoc because we have multiple repos.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@julienrf julienrf merged commit 577714f into sbt:develop Jun 20, 2023
2 checks passed
@julienrf julienrf deleted the scalacenter-transfer branch June 20, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants