Added Scala and SBT path fragments for Ivy repo pattern #895
Conversation
|
I just signed the CLA. |
| @@ -40,7 +40,7 @@ The default configuration file for sbt as an application looks like: | |||
|
|
|||
| [repositories] | |||
| local | |||
| typesafe-ivy-releases: http://repo.typesafe.com/typesafe/ivy-releases/, [organization]/[module]/[revision]/[type]s/[artifact](-[classifier]).[ext], bootOnly | |||
| typesafe-ivy-releases: http://repo.typesafe.com/typesafe/ivy-releases/, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext], bootOnly | |||
There was a problem hiding this comment.
But typesafe-ivy-releases hosts sbt 0.13 artifacts like this https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt/0.13.18/ so I am not sure if this is necessary.
There was a problem hiding this comment.
Ah ok, didn't realize that it was that they were for. I just used this line as a template for setting up our own repos, which then failed. The other option I see would be to document scalaVersion and sbtVersion.
There was a problem hiding this comment.
You need those to resolve extra properties set on sbt plugins. So https://github.com/sbt/website/blob/develop/src/reference/02-DetailTopics/03-Dependency-Management/04-Proxy-Repositories.md does say:
my-ivy-proxy-releases: http://repo.company.com/ivy-releases/, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]
There was a problem hiding this comment.
Maybe it's better to add:
# not actually in the default launcher, but added for documentation
my-ivy-proxy-releases: http://repo.company.com/ivy-releases/, [organization]/[module]/(scala_[scalaVersion]/)(sbt_[sbtVersion]/)[revision]/[type]s/[artifact](-[classifier]).[ext]
my-maven-proxy-releases: http://repo.company.com/maven-releases/
rather than changing typesafe-ivy-releases from what's actually being shipped.
Needs them to talk to Ivy repos, see https://github.com/sbt/website/edit/develop/src/reference/02-DetailTopics/03-Dependency-Management/04-Proxy-Repositories.md.