Display error messages based on the transformed positions when source mapping is perfomed #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to improve Twirl's error message with Scala3. playframework/twirl#498 This pull request makes sbt ignore `Problem#rendered` passed from the compiler if source mapping is actually performed. Sbt will display the error message based on the `Position` transformed by source mapping. When the source mapping is not performed, the message in `Problem#rendered` is displayed as before.
eed3si9n
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to improve Twirl's error message with Scala3.
playframework/twirl#498
As I commented here, I think it is better to solve this problem on sbt's side, instead of letting Dotty use
sourcePositionMappers.This pull request makes sbt ignore
Problem#renderedpassed from the compiler if source mapping is actually performed.Sbt will display the error message based on the
Positiontransformed by source mapping.When the source mapping is not performed, the message in
Problem#renderedis displayed as before.