Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-compiler, scala-library to 2.13.10 #1134

Closed

Conversation

scala-steward
Copy link
Contributor

Updates

from 2.13.8 to 2.13.10.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (2.13.8).
You might want to review and update them manually.

zinc/src/sbt-test/macros/macro-arg-dep-nested/build.json
zinc/src/sbt-test/macros/macro-arg-dep-stackoverflow/build.json
zinc/src/sbt-test/macros/macro-arg-dep/build.json
zinc/src/sbt-test/macros/macro/build.json
zinc/src/sbt-test/source-dependencies/java-class-invs/build.json
zinc/src/sbt-test/source-dependencies/subproject-api-update/build.json
zinc/src/sbt-test/source-dependencies/subproject-java/build.json
zinc/src/sbt-test/source-dependencies/subproject-pipelining-mixed/build.json
zinc/src/sbt-test/source-dependencies/subproject-pipelining-noclobber/build.json
zinc/src/sbt-test/source-dependencies/subproject-pipelining-optout/build.json
zinc/src/sbt-test/source-dependencies/subproject-pipelining/build.json
zinc/src/sbt-test/source-dependencies/trait-local-change/build.json
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

@rhuddleston
Copy link
Contributor

Any update on getting this merged?

@rhuddleston
Copy link
Contributor

@eed3si9n Any thoughts on merging this?

@eed3si9n
Copy link
Member

eed3si9n commented Jun 1, 2023

We can't merge this as-is, given the test failures. I think earlier I was concerned about bumping Scala 2.13.x because of its regressions and scala-xml bumps, but mostly those are now resolved?

@eed3si9n eed3si9n closed this Jun 1, 2023
@eed3si9n eed3si9n reopened this Jun 1, 2023
@rhuddleston
Copy link
Contributor

rhuddleston commented Jun 1, 2023

I think maybe the errors are because this version needs to be swapped out in a few more places? https://github.com/search?q=repo%3Asbt%2Fzinc%202.13.8&type=code

or at least this one:

@rhuddleston
Copy link
Contributor

@eed3si9n let's see if #1196 passes the tests if so let's use this pull?

@eed3si9n eed3si9n closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants