Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common VSCode metals temp folders to .gitignore #1308

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 12, 2023

Before

Screenshot 2023-12-12 at 2 30 32 PM

(3k temp files from VSCode, metals and bloop detected by Git)

After

Screenshot 2023-12-12 at 2 30 43 PM

(0 temp file detected)

@Friendseeker Friendseeker changed the title Add common VSCode metals temp file to .gitignore Add common VSCode metals temp folders to .gitignore Dec 12, 2023
@SethTisue
Copy link
Member

In general we don't mind merging these sorts of additions, as there's no harm in it. But you might be happier just adding them to your personal global gitignore, then you won't need to have them added to every repo you work in.

@Friendseeker
Copy link
Member Author

In general we don't mind merging these sorts of additions, as there's no harm in it. But you might be happier just adding them to your personal global gitignore, then you won't need to have them added to every repo you work in.

Ah thanks! I completely forgot that personal .gitignore is a thing!

You are a godsend. I was wondering why some metal devs were apparently working on Zinc related stuff and they did not complain about the 3k temp files.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, what Seth said.

@eed3si9n eed3si9n merged commit 5eb0de1 into sbt:develop Dec 13, 2023
7 checks passed
@Friendseeker Friendseeker deleted the add-gitignore-for-metals branch December 16, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants