Do not use invalidationResults to compute next invalidations
#1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
reviewed
Dec 21, 2023
internal/zinc-core/src/main/scala/sbt/internal/inc/Incremental.scala
Outdated
Show resolved
Hide resolved
eed3si9n
reviewed
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
invalidationResultsinAnalysisCallbackis computed twice, once in API phase, once in dependency phase. It is not updated again after Java analysis, henceinvalidationResultscontains incorrect information for Java sources.Fix
Do not use
invalidationResultswhen computingCompileCycleResult.Trivia
I am not 100% certain yet, but this is probably the root cause of sbt/sbt#6183, as
invalidationResultsis added in Zinc 1.4.0 and Infinite incremental compilation sbt#6183 appears after Zinc 1.4.0 is releasedinvalidateTransitivelyflag is set with the PR change.c.c. @LaCuneta This should fix #1311 or at least partially fix it (if #1311 has multiple causes).