Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -nowarn flag to slience compiler warning during benchmarking #1320

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Dec 31, 2023

Issue

When running benchmarking, there's lots of compiler warnings from the projects being benchmarked on that do not provide any meaningful info.

Example:

[info] [warn] /tmp/sbt_c424be7/milessabin/shapeless/benchmark-target/62611554399e0d04466da95591253706b2d3020d/core/shared/src/main/managed/shapeless/polynbuilders.scala:445:8: reference to at is ambiguous;
[info] [warn] it is both defined in the enclosing trait Poly11Builder and inherited in the enclosing object build as method at (defined in trait Poly11)
[info] [warn] In Scala 2, symbols inherited from a superclass shadow symbols defined in an outer scope.
[info] [warn] Such references are ambiguous in Scala 3. To continue using the inherited symbol, write `this.at`.
[info] [warn] Or use `-Wconf:msg=legacy-binding:s` to silence this warning. [quickfixable]
[info] [warn]        at(tL(functions))
[info] [warn]        ^
[info] [warn] /tmp/sbt_c424be7/milessabin/shapeless/benchmark-target/62611554399e0d04466da95591253706b2d3020d/core/shared/src/main/managed/shapeless/polynbuilders.scala:485:8: reference to at is ambiguous;
[info] [warn] it is both defined in the enclosing trait Poly12Builder and inherited in the enclosing object build as method at (defined in trait Poly12)
[info] [warn] In Scala 2, symbols inherited from a superclass shadow symbols defined in an outer scope.
[info] [warn] Such references are ambiguous in Scala 3. To continue using the inherited symbol, write `this.at`.
[info] [warn] Or use `-Wconf:msg=legacy-binding:s` to silence this warning. [quickfixable]
[info] [warn]        at(tL(functions))
[info] [warn]        ^
[info] [warn] /tmp/sbt_c424be7/milessabin/shapeless/benchmark-target/62611554399e0d04466da95591253706b2d3020d/core/shared/src/main/managed/shapeless/polynbuilders.scala:525:8: reference to at is ambiguous;

Change

Silence these warnings

Validating the PR

The CI result now omits these warnings.

@Friendseeker Friendseeker changed the title Pass -nowarn flag to slience warning during benchmarking Pass -nowarn flag to slience compiler warning during benchmarking Dec 31, 2023
Fix compiler error

Fix compiler error again
@Friendseeker Friendseeker marked this pull request as ready for review December 31, 2023 01:54
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 7a2122e into sbt:develop Dec 31, 2023
7 checks passed
@Friendseeker Friendseeker deleted the nowarn-benchmark branch December 31, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants