support detecting dotty plugins

[liufengyun]

Fix sbt/sbt#4073

Another PR needed to change sbt/sbt project.

@eed3si9n : could you please advise about what I should do with the tests?

[lightbend-cla-validator]

Hi @liufengyun,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

[lightbend-cla-validator]

Hi @liufengyun,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

[eed3si9n]

Thanks @liufengyun for the contribution, and ripple PR sbt/sbt#4084.

@cunei How do I start a validation that uses both of these PRs? I get "(pending—Jenkins is reserved for jobs with matching label expression)"

[liufengyun]

@eed3si9n Thanks a lot, sbt/sbt#4084 is currently blocked by Dotty SBT1 upgrade: scala/scala3#3872 , I'll back to it once the Dotty PR is merged.

[liufengyun]

It seems the Jenkins CI is not testing the correct version of zinc, as this PR exactly changes the signature of compilerPlugins:

[sbt212] [error] /localhome/jenkinssbt/workspace/sbt-validator/target-0.9.12-toni3/project-builds/sbt212-8f336f88b59a57655fd5bd35b9b91adddcd85177/main/src/main/scala/sbt/Defaults.scala:2892:119: too many arguments (2) for method compilerPlugins: (classpath: Seq[java.io.File])Iterable[java.io.File]
[sbt212] [error]     val plugins = sbt.internal.inc.classpath.ClasspathUtilities.compilerPlugins(pluginClasspath, scalaInstance.isDotty(version))
[sbt212] [error]                                                                                                                       ^

The drone CI reports the following error:

java.lang.RuntimeException: zinc Classpath: Binary compatibility check failed!

Could you please advise @eed3si9n @cunei ?

[dwijnand]

I pushed a commit to fix MiMa.

for context: the method you're changing is private[sbt], so it's not meant to be used by any sbt plugin, so we can just filter it out for MiMa.

[liufengyun]

Thanks a lot @dwijnand !

[typesafe-tools]

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project	Reference	Commit
sbt	pull/4084/head	sbt/sbt@141d2a6
zinc	pull/529/head	87d0ecc
io	1.1.x	sbt/io@efd1597
librarymanagement	1.1.x	sbt/librarymanagement@c57a55d
util	1.1.x	sbt/util@435a1c4
website	1.1.x

❌ The result is: FAILED
(restart)

[liufengyun]

ping @eed3si9n : could you please review again this PR? Thanks.

[dwijnand]

LGTM. Thanks @liufengyun!

[liufengyun]

Thanks @dwijnand !