Make xsbt.CompilerInterface class name configurable #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/service
branch
2 times, most recently
from
3e4f119
to
be41938
Compare
dwijnand
reviewed
Aug 10, 2020
internal/compiler-bridge/src/main/scala/xsbt/CompilerInterface2.scala
Outdated
Show resolved
Hide resolved
internal/compiler-bridge/src/main/scala_2.13/xsbt/ConsoleInterface1.scala
Outdated
Show resolved
Hide resolved
internal/zinc-compile-core/src/main/scala/sbt/internal/inc/AnalyzingCompiler.scala
Outdated
Show resolved
Hide resolved
Fixes sbt#831 This is a future proofing step for the compiler bridge. As suggested by Guillaume this introduces an indirection using `java.util.ServiceLoader` so the class name of the compiler interface implementation can be configured. This also a smoke test to invoke these entry points using the brige.
This was referenced Aug 11, 2020
|
Looks like something went wrong as the diff now has a bunch of other unrelated changes. |
You mean the tests that I added? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #831
This is a future proofing step for the compiler bridge. As suggested by Guillaume this introduces an indirection using
java.util.ServiceLoaderso the class name of the compiler interface implementation can be configured.