Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(feat): to constructor #179

Closed

Conversation

AndreasHeine
Copy link
Contributor

No description provided.

@frederikaalund
Copy link
Member

Hi Andreas, thanks for creating this PR. Let me have a look. :)

Looks good! 👍 I only have one comment: Use None as the default value (to enable easier default chaining). In turn, use if val is None: val = "default val" inside the __init__ body. Does it make sense?

@frederikaalund
Copy link
Member

Exactly, great job! :)

Last thing: Give yourself contribution credit in CHANGELOG.md. After that, I'll merge the PR right away. Thanks again!

@AndreasHeine AndreasHeine marked this pull request as ready for review January 10, 2023 11:08
@frederikaalund
Copy link
Member

LGTM!

I'd like to merge this right away but there are merge conflicts.

Two options from here:

  1. Use git rebase -i (or similar) to resolve the conflicts. I think the two commits from the pre-commit bot accidentally found their way into this PR.
  2. Create a new PR with the same changes but a "clean" commit history without conflicts.

Does it make sense? :)

@AndreasHeine
Copy link
Contributor Author

@frederikaalund hm somehow it does not show any conflicts....

@AndreasHeine
Copy link
Contributor Author

#180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants