Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aiomqtt has no attribute __version__ #273

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

vvanglro
Copy link
Contributor

@vvanglro vvanglro commented Feb 2, 2024

Close #272 .

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13b44fb) 85.1% compared to head (62333e5) 86.6%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #273     +/-   ##
=======================================
+ Coverage   85.1%   86.6%   +1.4%     
=======================================
  Files          6       6             
  Lines        425     427      +2     
  Branches      83      83             
=======================================
+ Hits         362     370      +8     
+ Misses        37      33      -4     
+ Partials      26      24      -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@empicano
Copy link
Collaborator

LGTM 👍 I added the version requirement >=1.0.0 for poetry-dynamic-versioning in pyproject.toml to make sure that the version tuple is also updated, because that didn't work for me at first. Thanks for another great PR, @vvanglro! 😊

@empicano empicano merged commit b17c310 into sbtinstruments:main Feb 21, 2024
12 checks passed
@vvanglro vvanglro deleted the fix/package_version branch February 21, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'aiomqtt' has no attribute '__version__'
2 participants