-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for tls_set in README.md #128
Conversation
Thank you for opening this PR. Let me have a look. :) Looks good and I think that it will help our users with the recently-added functionality (thanks again on that part). One minor nitpick: Let's send the example code through Black first. When that is done, I'll merge this. 👍 |
Hmmm, do I have to use black on the README.md or just the example code part and then commit that? |
Just the example code, thanks. :) It formats python code in a standard way. IMHO, it's a good idea to run it on all python code that goes into this repo. |
Just added the formatted example code. If this is alright, I would also like to add the |
Looks great, thanks!
Please, by all means go ahead. :) |
@frederikaalund I have added the documentation for the proxy settings as well. It is complete now |
LGTM. This will definitely help our users since we were pretty light on the documentation beforehand. Thanks again for your contribution to asyncio-mqtt. 👍 |
It was my pleasure :) |
Looking forward to that. Thanks again! 👍 |
I just wanted to ask for improvements and suggestions when adding the recent changes to the README.md
If this is alright (for now, just tls_set example added) I can add the proxy settings as well