Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change publishing tooling #151

Merged
merged 7 commits into from
Nov 7, 2022

Conversation

JonathanPlasse
Copy link
Collaborator

@JonathanPlasse JonathanPlasse commented Nov 6, 2022

Close #142 and #143

  • Change from setup.py to pyproject.toml.
  • Use setuptools-scm to generate the version based on tags.
  • Add continuous integration to publish asyncio-mqtt to PyPI when creating a release.
  • Update the changelog to prepare for a release

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #151 (2430726) into master (0e3c83f) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #151     +/-   ##
========================================
- Coverage    89.4%   89.4%   -0.1%     
========================================
  Files           8       7      -1     
  Lines         549     548      -1     
  Branches      109     109             
========================================
- Hits          491     490      -1     
  Misses         37      37             
  Partials       21      21             
Impacted Files Coverage Δ
asyncio_mqtt/__init__.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JonathanPlasse
Copy link
Collaborator Author

@empicano, is it ok with you to add you as a maintainer in the metadata of asyncio-mqtt?
@frederikaalund, can you double-check?

@empicano
Copy link
Owner

empicano commented Nov 6, 2022

@empicano, is it ok with you to add you as a maintainer in the metadata of asyncio-mqtt?

Sure! 👍

Lots of automation we're getting here, very cool!

Copy link
Collaborator

@frederikaalund frederikaalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Super to see all these improvements to our tooling. Sure beats my previous manual use of twine. 😄

Nice use of [tool.setuptools_scm] to set the version.

Really great to see that you updated the changelog as well. 👍 That's what takes the longest for me whenever I do a release.

~Frederik

@JonathanPlasse
Copy link
Collaborator Author

@empicano, @frederikaalund, We should update the changelog in each pull request instead of all at once before a release. I added it to CONTRIBUTING.md.
Also, should we deprecate the master branch in favor of the main branch?

@frederikaalund
Copy link
Collaborator

We should update the changelog in each pull request instead of all at once before a release. I added it to CONTRIBUTING.md.

I agree. 👍 Should be a requirement of each PR. We do have to be a bit lenient with external users in practice, though. Otherwise, the barrier to contribution becomes too high.

Also, should we deprecate the master branch in favor of the main branch?

Sure, why not. :)

@JonathanPlasse JonathanPlasse merged commit 07ddcaa into empicano:master Nov 7, 2022
@JonathanPlasse
Copy link
Collaborator Author

JonathanPlasse commented Nov 7, 2022

@frederikaalund, can you remove the tag v0.14.0? The publishing did not work as my email address was not considered valid.

@frederikaalund
Copy link
Collaborator

@frederikaalund, can you remove the tag v0.14.0? The publishing did not work as my email address was not considered valid.

Done as per the other thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace setup.py by pyproject.toml
3 participants