-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change publishing tooling #151
Change publishing tooling #151
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
========================================
- Coverage 89.4% 89.4% -0.1%
========================================
Files 8 7 -1
Lines 549 548 -1
Branches 109 109
========================================
- Hits 491 490 -1
Misses 37 37
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@empicano, is it ok with you to add you as a maintainer in the metadata of |
Sure! 👍 Lots of automation we're getting here, very cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Super to see all these improvements to our tooling. Sure beats my previous manual use of twine
. 😄
Nice use of [tool.setuptools_scm]
to set the version.
Really great to see that you updated the changelog as well. 👍 That's what takes the longest for me whenever I do a release.
~Frederik
@empicano, @frederikaalund, We should update the changelog in each pull request instead of all at once before a release. I added it to |
I agree. 👍 Should be a requirement of each PR. We do have to be a bit lenient with external users in practice, though. Otherwise, the barrier to contribution becomes too high.
Sure, why not. :) |
@frederikaalund, can you remove the tag |
Done as per the other thread. |
Close #142 and #143
setup.py
topyproject.toml
.setuptools-scm
to generate the version based on tags.asyncio-mqtt
to PyPI when creating a release.