Datajck4 #89
Merged
Datajck4 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
clicman
commented
Sep 8, 2018
clicman
commented
- Update to datajack-4.0.2
- Do not fetch all providers by default. Add dependency to the final project only.
sbtqasonar
reviewed
Sep 8, 2018
sbtqasonar
reviewed
Sep 10, 2018
| try { | ||
| return (List<Tag>) FieldUtils.readField(scenarioDefinition, "tags", true); | ||
| } catch (IllegalArgumentException | IllegalAccessException e) { | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
R we gonna mutate this one? If no I suggest to use Collections.EMPTY_LIST to avoid memory allocation
page-factory-core/src/main/java/ru/sbtqa/tag/pagefactory/data/DataParser.java
Show resolved
Hide resolved
| String parsedValue = DataFactory.getInstance().get(dataPath).getValue(); | ||
| replacedStep = replacedStep.replace(stepDataMatcher.start(3) - 1 + offset, stepDataMatcher.end(3) + offset, parsedValue); | ||
| offset += parsedValue.length() - 1 - value.length(); | ||
| String builtPath = collection == null ? "$" + value : "$" + collection + value; |
There was a problem hiding this comment.
"$" + (collection == null ? "" : collection) + value
sbtqasonar
reviewed
Sep 10, 2018
| dataFolder, | ||
| initialCollection | ||
| ); | ||
| break; | ||
| case "mongo": | ||
| testDataProvider = initProvider(PROVIDERS.MONGO_DATA_PROVIDER, | ||
| new MongoClient(new MongoClientURI(Props.get("data.uri"))).getDB("data.db"), |
There was a problem hiding this comment.
| try { | ||
| return (List<Tag>) FieldUtils.readField(scenarioDefinition, "tags", true); | ||
| } catch (IllegalArgumentException | IllegalAccessException e) { | ||
| return Collections.EMPTY_LIST; |
There was a problem hiding this comment.
| dataFolder, | ||
| initialCollection | ||
| ); | ||
| break; | ||
| case "mongo": | ||
| testDataProvider = initProvider(PROVIDERS.MONGO_DATA_PROVIDER, | ||
| new MongoClient(new MongoClientURI(Props.get("data.uri"))).getDB("data.db"), |
There was a problem hiding this comment.
PavelAlennikov
approved these changes
Sep 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.