Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a more heavily typed API #19

Merged
merged 3 commits into from Apr 17, 2019
Merged

Convert to a more heavily typed API #19

merged 3 commits into from Apr 17, 2019

Conversation

sburba
Copy link
Owner

@sburba sburba commented Apr 16, 2019

Adapters must now implement an Adapter interface, add a new "Type" abstraction that makes it easier to validate passed in types.

This is a breaking change. Several breaking changes actually.

Sam Burba added 3 commits April 16, 2019 19:05
Adapters must now implement an Adapter interface, add a new "Type" abstraction that makes it easier to validate passed in types
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #19   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       72     82   +10     
=======================================
  Files             6      7    +1     
  Lines           163    185   +22     
=======================================
+ Hits            163    185   +22
Impacted Files Coverage Δ Complexity Δ
src/JsonContext.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/JsonFormatException.php 100% <100%> (ø) 1 <1> (-2) ⬇️
src/StrictJson.php 100% <100%> (ø) 34 <32> (-20) ⬇️
src/InvalidConfigurationException.php 100% <100%> (ø) 1 <1> (ø) ⬇️
src/StrictJsonBuilder.php 100% <100%> (ø) 5 <4> (+1) ⬆️
src/Type.php 100% <100%> (ø) 31 <31> (?)
src/ArrayAdapter.php 100% <100%> (ø) 4 <4> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8512a09...580ffbb. Read the comment docs.

@sburba sburba merged commit a2ea003 into master Apr 17, 2019
@sburba sburba deleted the feature/typed-api branch April 17, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant