Skip to content

Commit

Permalink
Make scripts crash on unhandled rejections (facebook#1819)
Browse files Browse the repository at this point in the history
* Makes end-to-end testing crash on unhandled rejections

* Comment fix
  • Loading branch information
dbismut authored and Timer committed Mar 14, 2017
1 parent a34d48a commit 42ebfc9
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 0 deletions.
7 changes: 7 additions & 0 deletions scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
// Do this as the first thing so that any code reading it knows the right env.
process.env.NODE_ENV = 'production';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
throw err;
});

// Load environment variables from .env file. Suppress warnings using silent
// if this file is missing. dotenv will never modify any environment variables
// that have already been set.
Expand Down
7 changes: 7 additions & 0 deletions scripts/eject.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
*/
'use strict';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
throw err;
});

const fs = require('fs-extra');
const path = require('path');
const spawnSync = require('cross-spawn').sync;
Expand Down
7 changes: 7 additions & 0 deletions scripts/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
*/
'use strict';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
throw err;
});

const fs = require('fs-extra');
const path = require('path');
const spawn = require('cross-spawn');
Expand Down
7 changes: 7 additions & 0 deletions scripts/start.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,13 @@
// @remove-on-eject-end
'use strict';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
throw err;
});

process.env.NODE_ENV = 'development';

// Load environment variables from .env file. Suppress warnings using silent
Expand Down
7 changes: 7 additions & 0 deletions scripts/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@
process.env.NODE_ENV = 'test';
process.env.PUBLIC_URL = '';

// Makes the script crash on unhandled rejections instead of silently
// ignoring them. In the future, promise rejections that are not handled will
// terminate the Node.js process with a non-zero exit code.
process.on('unhandledRejection', err => {
throw err;
});

// Load environment variables from .env file. Suppress warnings using silent
// if this file is missing. dotenv will never modify any environment variables
// that have already been set.
Expand Down

0 comments on commit 42ebfc9

Please sign in to comment.