Fix build on GCC 13 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 13 stopped transitively including `cstdint` in a couple of
scenarios [1], which leads to build failures akin to:
```
[ 25%] Building CXX object src/general/CMakeFiles/General.dir/file.cpp.o
In file included from /build/source/src/general/file.cpp:1:
/build/source/src/general/file.h:10:27: error: 'uint8_t' was not declared in this scope
10 | void readFile(std::vector<uint8_t> &res, const char *fname,
| ^~~~~~~
/build/source/src/general/file.h:8:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
7 | #include "error.h"
+++ |+#include <cstdint>
8 |
```
[1]: https://www.gnu.org/software/gcc/gcc-13/porting_to.html#header-dep-changes
mfrischknecht
added a commit
to mfrischknecht/nixpkgs
that referenced
this pull request
Jan 25, 2024
`grip-search` stopped building on GCC13 due to the standard `cstdint` header not getting transitively included through other standard headers anymore. This change pulls in a patch from an open upstream PR [1] that adds the necessary includes. Since the current `substituteInPlace` patch that to the built-in version string was overriding the `patches` phase (preventing a simple declarative listing of patches to be applied), I moved it to the `postPatch` hook instead. [1]: sc0ty/grip#6
|
Thanks for the fix |
kylechui
pushed a commit
to kylechui/nixpkgs
that referenced
this pull request
Feb 10, 2024
`grip-search` stopped building on GCC13 due to the standard `cstdint` header not getting transitively included through other standard headers anymore. This change pulls in a patch from an open upstream PR [1] that adds the necessary includes. Since the current `substituteInPlace` patch that to the built-in version string was overriding the `patches` phase (preventing a simple declarative listing of patches to be applied), I moved it to the `postPatch` hook instead. [1]: sc0ty/grip#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 13 stopped transitively including
cstdintin a couple of scenarios 1, which leads to build failures akin to:As an example of this issue in the wild, see this Nixpkgs CI failure:
Build: https://hydra.nixos.org/build/246246828
Build log: https://hydra.nixos.org/build/246246828/nixlog/1
This change includes
cstdintingeneral/file.handgeneral/filelist.h, fixing the build on current GCC versions.Footnotes
https://www.gnu.org/software/gcc/gcc-13/porting_to.html#header-dep-changes ↩