Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace map names with Liquipedia links. #60

Open
nephest opened this issue Mar 2, 2023 · 2 comments
Open

Replace map names with Liquipedia links. #60

nephest opened this issue Mar 2, 2023 · 2 comments
Labels
Projects

Comments

@nephest
Copy link
Collaborator

nephest commented Mar 2, 2023

  • Matches tab in the player view.
  • Format: <a href="https://liquipedia.net/starcraft2/Map_name_with_underscores" rel="noopener" target="_blank">Map name</a>.
  • _1v1, _2v2, _3v3, _4v4, Archon match types.

Where to start:

mapCell.textContent = match.map.name;

@nephest nephest created this issue from a note in Ideas (Low Priority) Mar 2, 2023
@nephest nephest added good first issue Good for newcomers front end labels Mar 2, 2023
@AngusMacrae
Copy link

Hi - I'm happy to pick this up if it'd be helpful? Amazing work on sc2pulse btw, I dropped out of the sc2 scene for a year or two and came back recently, great to see a replacement for rankedftw exists :) (well, it's better than rankedftw tbh)

@nephest
Copy link
Collaborator Author

nephest commented Apr 22, 2024

Hello. Thanks!
The issue is still relevant, but it's quite old so some things have changed. Previously I provided DB dumps so that other devs could easily create local DB. There is no DB dumps now, so we have to decide what to do instead. Let me know which option you prefer.

  • You can change ROOT_CONTEXT_PATH to https://sc2pulse.nephest.com/sc2/ and disable CORS in your browser. This way you will use the prod endpoints with real data. Useful for front end changes.
  • I could add DB dumps again next week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Ideas
Low Priority
Development

No branches or pull requests

2 participants