Rewrite/generics #11
Closed
Rewrite/generics #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fernthedev
force-pushed
the
rewrite/generics
branch
2 times, most recently
from
e8797b9
to
98b11e5
Compare
Fernthedev
force-pushed
the
rewrite/generics
branch
from
f5b02e2
to
6a9e141
Compare
Fernthedev
force-pushed
the
rewrite/generics
branch
from
a850e3e
to
06e7701
Compare
…into rewrite/generics
…into rewrite/generics
…into rewrite/generics
…into rewrite/generics
…into rewrite/generics
…into rewrite/generics
…into rewrite/generics
Offsets for NON explicit layouts should be correctly generated for both generic and non-generic types. Currently extremely redundant generation and sizes are not truly verified against, as two computations occur: 1. To obtain the size 2. To compute all the offsets but these are split up across two different call points for no reason. In the future, we should merge these calls together, and cache all fills (as a given generic type with a single typedef may be filled hundreds of times over the course of its children and its own instantiations)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.