Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMIME signature exception does not seem to work #39

Closed
michaelweiser opened this issue Sep 21, 2018 · 4 comments · Fixed by #113
Closed

SMIME signature exception does not seem to work #39

michaelweiser opened this issue Sep 21, 2018 · 4 comments · Fixed by #113
Assignees
@michaelweiser
Labels
needs investigation
Milestone
2.0

Comments

@michaelweiser
Copy link
Contributor

We need to retest if our SMIME attachment exception to avoid false positives actually works. There have been reports that it doesn't.
This was referenced Sep 21, 2018
Closed
Closed
@michaelweiser michaelweiser self-assigned this Sep 21, 2018
@michaelweiser michaelweiser added this to the 1.7 milestone Sep 21, 2018
@michaelweiser
Copy link
Contributor Author

Wait until #29 is merged because that might fix it incidentally.

@michaelweiser
Copy link
Contributor Author

@Jack28: Do you perhaps have a test case (email) floating around that should trigger the problem?

@michaelweiser michaelweiser modified the milestones: 1.7, 2.0 Apr 23, 2019
@michaelweiser michaelweiser mentioned this issue May 7, 2019
Closed
@Jack28
Copy link
Member

Jack28 commented Aug 27, 2019

#96 solves this

@Jack28 Jack28 closed this as completed Aug 27, 2019
@Jack28
Copy link
Member

Jack28 commented Oct 2, 2019

smime attachments are also smime.p7m

I propose a change to the rule to:

sample.meta_info_name_declared == 'smime.p7[sm]'

@Jack28 Jack28 reopened this Oct 2, 2019
@Jack28 Jack28 mentioned this issue Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelweiser michaelweiser

Labels
needs investigation
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Adds ignore to smime rule for p7m and p7c Jack28/PeekabooAV
2 participants
@michaelweiser @Jack28