Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shipping log section with the last 3 posts from the blog #97

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Pabl0cks
Copy link
Collaborator

@Pabl0cks Pabl0cks commented May 13, 2024

Had to build the widget for it, tried to follow the same logic to fetch the data and style it with Chakra.

A couple of notes:

  • Initially tried coding the data fetching in the front but I was getting CORS errors (because of localhost I believe), so moved it to the server just in case.
  • Using substack RSS to fetch the posts, I'm assuming that the RSS will continue being ordered by date, but maybe I should add a manual order by date just in case it changes in the future?

We could also add a subscribe widget from substack below the posts if we see it interesting:

image

Screenshots:

image
image

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buidlguidl-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:12am

@@ -64,6 +68,7 @@ export default function Index({ bgStats, events }) {
export async function getStaticProps() {
const stats = await getStats();
const events = await getAllEvents(null, 10);
const posts = await fetchRecentPosts();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe get is more consistent than fetch :D

@carletex
Copy link
Member

Thanks for experimenting with this @Pabl0cks !!

Just a general comment about this section: I don't think it adds much value as it's displayed right now. The title & picture are almost the same on every post, it just changes the description a bit, so I don't really see the point of the section itself.

Like for me, A more valuable section will be something like:

  • Image for the whole Newsletter + Title (🛳 BG Shipping Log)
  • Sign up form
  • Maybe a link to past issues in a more "link manner" (vs card). 1, 2, 3 entries or whatever.

What do you all think?

Maybe this is something we should have talked before, but I personally didn't pay much attention to it when Andrea sent it, since I was focused in the other parts. Sorryt!

(Note: the Vercel deployment won't work since the backend is deployed on GAE)

@technophile-04
Copy link
Contributor

TYSM @Pabl0cks !! Really nice work !!

The title & picture are almost the same on every post, it just changes the description a bit, so I don't really see the point of the section itself.
Like for me, A more valuable section will be something like:

  1. Image for the whole Newsletter + Title (🛳 BG Shipping Log)
  2. Sign up form
  3. Maybe a link to past issues in a more "link manner" (vs card). 1, 2, 3 entries or whatever.

Visually I think it looks great, but totally agree with these points and makes more sense to have single section highlighting the main things

@Pabl0cks
Copy link
Collaborator Author

Thank you for the feedback! 🙌♥

The title & picture are almost the same on every post, it just changes the description a bit, so I don't really see the point of the section itself.

Like for me, A more valuable section will be something like:

  • Image for the whole Newsletter + Title (🛳 BG Shipping Log)
  • Sign up form
  • Maybe a link to past issues in a more "link manner" (vs card). 1, 2, 3 entries or whatever.

💯 Agree, cards feels too repetitive with their current content. Will talk with Andrea to create a new version of the section.

Base automatically changed from stage to master May 17, 2024 09:24
@andrealbiac
Copy link

Posting the design updates here too:

Captura de pantalla 2024-05-22 a las 12 14 21 Captura de pantalla 2024-05-22 a las 12 19 27

I think I prefer the second one, with the submission form below the picture, cause it's a bit more compact and the info is more organised (to my eye) ✌🏻

@Pabl0cks
Copy link
Collaborator Author

Thanks Andrea!

I think I prefer the second one, with the submission form below the picture, cause it's a bit more compact and the info is more organised (to my eye) ✌🏻

Started working yesterday on this. I'm afraid it won't be possible to tweak styles from Substack (there are some technical limitations with <iframe> styling when you are loading external websites, if I understood correctly from link1 or link2)
All I found were hacky workarounds with jquery that I'm not confident they would even work, and probably not worth it, even if they do.

So 2nd option seem the best to me too, since we won't be able to get rid of the watermark and legal notice.

Haven't pushed the changes, still working on the RWD. This is how it's looking on laptop:

image

The problem is since I can't change embedded background, in dark mode it must be white also 😬

image

What do you think about that? Should we skip adding the embedded subscribe widget?

@andrealbiac
Copy link

Hey, sorry for the late reply
It's a shame we can't modify it in the end! And that they don't have a dark mode version :/

I agree in that case that design is the best option, to me it looks very good in light mode. But what would be the other option if we want to avoid the dark mode problem? To have our own button instead of the widget + that takes you to the substack page?

Also curious to know others opinions :)

@Pabl0cks
Copy link
Collaborator Author

I agree in that case that design is the best option, to me it looks very good in light mode. But what would be the other option if we want to avoid the dark mode problem? To have our own button instead of the widget + that takes you to the substack page?

Yeah! 😥 Probably a button with a CTA to go to substack to subscribe. "Subscribe in Substack", "Open Substack" or something similar.

@andrealbiac
Copy link

Yeah, it's a pity but I guess that's the best option if we can't solve the dark mode issue.. Otherwise it's a bit weird that only that section stays in white no?

To me 'Subscribe in Substack' or just 'Subscribe' is good for the button 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants