Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'use client' from EtherInput, IntegerInput, and AddressInput to Resolve Serialization Lint Warning #688

Merged
merged 2 commits into from Jan 22, 2024

Conversation

KcPele
Copy link
Contributor

@KcPele KcPele commented Jan 15, 2024

Description

Removed "use client" from EtherInput IntergerInput and AddessInput due to lint-warning: Props must be serializable for components #686
There is no need for a child component to have "use client" when the parent contains "use client" already vercel/next.js#46795
Concise description of proposed changes, We recommend using screenshots and videos for better description

Additional Information

Related Issues

Closes #{issue number}

Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.

Your ENS/address:

Copy link
Collaborator

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@technophile-04
Copy link
Collaborator

Thanks, @KcPele , could you also please check what are others place / Component which receives props like onChange , setState etc (their name could be different)

Maybe go through the components which are using "use client" directive and make sure they are not accepting any non-serializable things eg functions and if they are could you please remove it

thanks 🙌

@KcPele
Copy link
Contributor Author

KcPele commented Jan 18, 2024 via email

@technophile-04
Copy link
Collaborator

Got it thanks @KcPele 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants