Challenge 0 wagmi 2 backmerge #171
Conversation
* backmerge wagmi v2 * feat: update rainbowkit button styles
…2-challenges into challenge-0-wagmi-2-backmerge
…2-challenges into challenge-0-wagmi-2-backmerge
There was a problem hiding this comment.
TY @rin-st it's looking nice, GJ!
Just a couple of issues to check (nitpicks in this Challenge, but more to check if we got some bug to fix in SE-2 wagmiV2):
- When clicking on "Transfers" tab we get this error:
Error: Contract not found, but the information loads correctly. - When you paste an address on the "Transfer To" field for the first time after loading the "My NFTs" tab, we get a small flickering. Video here
You mean error in console, right? Added a quick fix for now. But looks like it's an at least 5-month old error, will add pr to se-2 soon
It's because of skeleton loading - input becomes wider, and hence card too. You can try to use ens names inside input, you'll see that card becomes wide. It worked that way already, I don't see the good way to fix it. We can fix width of the image so it will not widen on ens loading. So it will look like instead of |
|
created an issue for image width fix, I think it's better to fix it a bit later #172 |
|
useScaffoldEventHistory update pr (could be merged later) |
Yeah! Just checked the SE-2 PR 🔥♥. Since we are still with Ch. 0, should we wait to merge it, and then backmerge it to base & chal0 so is fixed on all challenges in this PR iteration?
Ok! It was a very nitpicky thing, only commented it because it seemed to me that in an older version of Chal. 0 it was not happening, if not I wouldn't have raised it here probably 🙌 |
Yes, let's wait then
It exists since start :) |
* feat: update events hook and static params * fix: deployed contracts
…2-challenges into challenge-0-wagmi-2-backmerge
Added events hook change and scaffold-eth/scaffold-eth-2#825 . Working fine for me, hope for you too 😄 I think I'll merge it again together with challenges 1 and 2 |
Working well to me!
💯 |
…2-challenges into challenge-0-wagmi-2-backmerge
…2-challenges into challenge-0-wagmi-2-backmerge
|
Added last changes, tested. Working fine. |
|
I'm getting a strange render problem with the copy address button with the "View QR Code" option from RainbowKit. If I view QR from a Metamask wallet, it's fine, but if I'm connected to burner wallet, copy icon renders super small:
|
|
The challenge is still working fine to me. Should we change the spacing in If we decide to tweak something, I'd probably just do it in se-2 and backmerge it in the next big backmerge to challenges, since is a really minor bug. |
You can create pr to se-2 and we'll add it to the current backmerge. Looks like we need to fix other bugs related to wagmi 2 in the current backmerge anyway |
Tried reproducing it in SE-2, it's not happening for the same address. The problem is a combination of Challenges font and some longer weight addresses due to their characters size. Should we change spacing a bit in SE-2 to fix that edge case (and other posible builds with SE-2 and big weight fonts), or should just leave it like that. |
|
I think it's better to fix it in se-2 |
…2-challenges into challenge-0-wagmi-2-backmerge
|
Did last tests, looking good! 🙌 |
…2-challenges into challenge-0-wagmi-2-backmerge
|
While doing a fast check with the last burner commits on the challenges, realized of a SE-2 issue with the burner, a bit edge case, but maybe is good to add the fix when we have it. |
|
Merging this since the burner issue is closed. Thank you a lot @Pabl0cks ! ❤️ |
No description provided.