Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp list view of available streams #43

Closed
Magic815 opened this issue Feb 1, 2016 · 12 comments
Closed

Revamp list view of available streams #43

Magic815 opened this issue Feb 1, 2016 · 12 comments

Comments

@Magic815
Copy link

Magic815 commented Feb 1, 2016

While this is mostly a cosmetic issue, the list view of available streams in Pulsar left a lot to be desired.

When Pulsar was set up to show all available streams, the list contained entries that were simply just long concatenated lines of info that contained seeders, leechers, size, name, and sometimes the provider. On a lot of skins, the entries became so wide that the text auto-scrolled and became hard to read.

I was thinking it'd would be great to try and parse some of the info out into a more readable format. Can size, resolution, and name all get parsed out? If so, maybe something like the following "multi-line" approach?

Available Streams for "The Prestige"

(76 / 24) 1080p [23.5 GB] - Kickass Torrents
The.Prestige.1080p.BluRay.SPaRKs.mkv

(51 / 12) 720p [12.7 GB] - Kickass Torrents
The.Prestige.720p.BluRay.SPaRKs.mkv

etc.

I think step one would just be getting the entries to stop auto-scrolling so that they can be easily read. But then step two would be adding some polish to the view in a similar fashion to above.

@corrpel
Copy link

corrpel commented Feb 1, 2016

+1. I think file size shoud be first (in gb rounded), second rezolution and
3rd the file name
On Feb 1, 2016 7:50 PM, "Magic815" notifications@github.com wrote:

While this is mostly a cosmetic issue, the list view of available streams
in Pulsar left a lot to be desired.

When Pulsar was set up to show all available streams, the list contained
entries that were simply just long concatenated lines of info that
contained seeders, leechers, size, name, and sometimes the provider. On a
lot of skins, the entries became so wide that the text auto-scrolled and
became hard to read.

I was thinking it'd would be great to try and parse some of the info out
into a more readable format. Can size, resolution, and name all get parsed
out? If so, maybe something like the following "multi-line" approach?

Available Streams for "The Prestige"

(76 / 24) 1080p [23.5 GB] - Kickass Torrents
The.Prestige.1080p.BluRay.SPaRKs.mkv

(51 / 12) 720p [12.7 GB] - Kickass Torrents
The.Prestige.720p.BluRay.SPaRKs.mkv

etc.

I think step one would just be getting the entries to stop auto-scrolling
so that they can be easily read. But then step two would be adding some
polish to the view in a similar fashion to above.


Reply to this email directly or view it on GitHub
#43.

@nix87
Copy link

nix87 commented Feb 1, 2016

I think in future we could see that, but so far developers are focused on more tehnical features. I belive cosmetic changes will come later when all project become 100% stable.

But I must say it's a realy nice suggestion which I would like to see in future +1

@scakemyer
Copy link
Owner

I'm also really annoyed by this, so I'll be looking into this as soon as I can. However I'm afraid it might be a little complicated since we're using standard Kodi dialogs, and our options are limited in terms of how to display the information.

@hfmls
Copy link

hfmls commented Feb 2, 2016

i would like this too. size is more important sometimes doesn't even show up

@corrpel
Copy link

corrpel commented Feb 2, 2016

+1 yep only seeds are more important that the size.
So, we can keep the dialogue and use it like this:
[seeds,filesize(GB),torrent-name,provider**<1>**]

<1> - use only the first two letters from each provider name words.

edit:
also, is there any way to make the dialogue larger?

@hfmls
Copy link

hfmls commented Feb 3, 2016

yes, wider please

@scakemyer
Copy link
Owner

So that's started, but I'll work on a two-line display like @Magic815 proposed, that'll be much better

@corrpel
Copy link

corrpel commented Feb 5, 2016

@scakemyer were should we modify the fonts for size?
i tried replacing everything related to the fonts in addonwindow.py, but no luck so far

@scakemyer
Copy link
Owner

Have you tried passing it as a parameter in dialog.py instead of changing addonwindow.py?

@scakemyer
Copy link
Owner

I'm opened to suggestions regarding improving this, it was really just a first draft for the revamp, but I think it came out pretty good already.

@nix87
Copy link

nix87 commented Feb 5, 2016

I love it. this is amazing work on search list!

It's easily the best search list of any addon I'm aware of.

@corrpel
Copy link

corrpel commented Feb 5, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants