Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis #332

Merged
merged 7 commits into from Oct 18, 2019
Merged

fix travis #332

merged 7 commits into from Oct 18, 2019

Conversation

@sideeffffect sideeffffect force-pushed the fix-travis branch 6 times, most recently from 79b1c62 to b299ca4 Compare November 11, 2018 00:57
@sideeffffect sideeffffect changed the title [WIP] fix travis fix travis Nov 11, 2018
@sideeffffect sideeffffect force-pushed the fix-travis branch 3 times, most recently from 21e5d02 to 6e9025b Compare November 11, 2018 01:49
@sideeffffect
Copy link
Contributor Author

sideeffffect commented Nov 11, 2018

It's now failing with

[info] [info] Compiling 3 Scala sources and 6 Java sources to /tmp/sbt_739e8f4/gen-android/target/scala-2.11/classes...
[info] [error] /tmp/sbt_739e8f4/gen-android/target/android/generated/source/org/scalaandroid/foo/TR.scala:47: type arguments [A] do not conform to method findViewById's type parameter bounds [V <: android.view.View]
[info] [error]   final def findView[A](tr: TypedResource[A]): A = findViewById[A](tr.id)
[info] [error]                                                                ^
[info] [error] one error found

and now it's failing with

[info] [info] Compiling 3 Scala sources and 6 Java sources to /tmp/sbt_ced74bf/gen-android/target/scala-2.11/classes...
[error] [Fatal Error] :3:214: The value of attribute "name" associated with an element type "item" must not contain the '<' character.
[error] Could not read /usr/local/android-sdk-25.2.3/platform-tools/api/annotations.zip
[error] java.io.IOException: Could not parse XML from android/accounts/annotations.xml
[error] 	at com.android.tools.lint.ExternalAnnotationRepository$AnnotationsDatabase.initializePackage(ExternalAnnotationRepository.java:912)

😭

@pfn any idea what could be going wrong?

@sideeffffect sideeffffect force-pushed the fix-travis branch 6 times, most recently from 2576bd3 to 978b67c Compare November 13, 2018 00:51
@pfn
Copy link
Member

pfn commented Nov 16, 2018

The former error is a android sdk selection issue. Probably needs to be at least android-24 or something; I'm not sure what the latter error is caused by.

@sideeffffect sideeffffect force-pushed the fix-travis branch 3 times, most recently from 823e578 to af16fe4 Compare November 16, 2018 21:55
@sideeffffect
Copy link
Contributor Author

@pfn I think I fixed the first issues with android-24 and findViewById
but when I tried googling for the annotations.xml issue, I couldn't find almost anything, only hints that people solved it by upgrading to a newer versions of Gradle -- so that's what I'm trying now...

@sideeffffect
Copy link
Contributor Author

sideeffffect commented Sep 19, 2019

let me reiterate from #340 (comment)

Thank you @jeffboutotte for this!!! 🙏 your work on making CI work again gives sbt-android hope to come to life again
we should merge this ASAP, to make other PRs possible
@pfn do you think you could do that?

@sideeffffect sideeffffect mentioned this pull request Sep 19, 2019
@sideeffffect
Copy link
Contributor Author

@pfn we have a green build. can you please merge?

@sideeffffect
Copy link
Contributor Author

@soc @pfn @taig @dant3
can you guys please merge this PR, or add this privilege to somebody who has time to accept PRs?
thank you :)

@taig
Copy link
Member

taig commented Oct 7, 2019

@sideeffffect I love to see you pushing this forward, but I don't want to merge a PR without @pfn's approval. Could you perhaps kick off a fork instead? It seems like @pfn is not maintaining this project actively anymore.

@pfn
Copy link
Member

pfn commented Oct 7, 2019 via email

Copy link
Member

@dant3 dant3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, however I would like for @pfn to make a final decision

@dant3 dant3 requested review from dant3 and pfn October 8, 2019 15:00
@sideeffffect
Copy link
Contributor Author

@taig @dant3 guys would you be open to helping out @pfn with reviewing and merging PR in the future?
there are some infrastructure changes that need to be done (like working CI, upgrading sbt to 1.x and so on) to keep this project alive, and the sooner that work gets merged the better

@pfn pfn merged commit 280b0dd into scala-android:master Oct 18, 2019
@pfn
Copy link
Member

pfn commented Oct 18, 2019

Thanks for your work @sideeffffect

@sideeffffect sideeffffect deleted the fix-travis branch February 4, 2020 18:34
doofin added a commit to doofin/sbt-android that referenced this pull request Apr 22, 2024
* Fix merge manifests (scala-android#336)

* Fix compiler error in generated code for platformAPI >= 26

* Update ManifestMerger to avoid exception when merging androidx WorkManager library

* Upgrade to sbt 1

* fix travis (scala-android#332)

* fix travis

https://stackoverflow.com/questions/28751111/invalid-abi-armeabi-v7a-for-the-selected-target-with-google-apis

travis-ci/travis-ci#8188

https://stackoverflow.com/questions/40272884/running-android-emulator-with-noaudio-option-returns-qemu-system-i386-exe-au

https://forums.adobe.com/thread/2538952

infinitered/ignite#1097

* Fix travis CI

* Travis badge 🎉

* Travis Cache fix

* Travis Cache fix, 2

* Ignore .idea directory

* Fix travis publishLocal tasks

* Don't explicitly publish plugin on travis, scripted does this automatically

* Undo last commit

* Run scripted tests in parallel to improve travis build time

* Update travis config for sbt 1.x

* Quote TEST_COMMAND in travis config

* Update gradle build tests to use sdk version 26 since travis installs that version

* Small change to retrigger travis

* Changed Typesafe Repo to https

* upg .gitignore, upg sbt sbt.version=1.5.5

* upg sbt,cleanup

* upg to scalaVersion := 2.12.19 , better err msg

* cleaup

* rm gradle

* cleaup sbt

* fix javac compile release,fmt

* fix lint

* fmt

* refactor

* try upg sbt

* add ci

* wip

---------

Co-authored-by: Trudy Firestone <trudyfirestone@gmail.com>
Co-authored-by: Jeff Boutotte <jeff_boutotte@ultimatesoftware.com>
Co-authored-by: Ondra Pelech <ondra.pelech@gmail.com>
Co-authored-by: jeffboutotte <jeffboutotte@gmail.com>
Co-authored-by: Chris Wewerka <c.wewerka@dasgip.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants