Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP - Evaluator client Apply with timeouts parameters #22

Merged
merged 2 commits into from
Aug 12, 2016
Merged

JP - Evaluator client Apply with timeouts parameters #22

merged 2 commits into from
Aug 12, 2016

Conversation

juanpedromoreno
Copy link
Contributor

Forgotten apply method in the previous PR.

Please, @raulraja @dialelo could you review? thanks!

@ghost
Copy link

ghost commented Aug 12, 2016

👍 LGTM, we could also use the FiniteDuration type to not allow infinite timeouts.

@juanpedromoreno juanpedromoreno mentioned this pull request Aug 12, 2016
Closed
@juanpedromoreno
Copy link
Contributor Author

Good point @dialelo , definitely: #24

@juanpedromoreno juanpedromoreno merged commit 74e52ef into master Aug 12, 2016
@juanpedromoreno juanpedromoreno deleted the jp-fix-eval-client-api-params branch August 12, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@juanpedromoreno