Memory leak bug fix #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpedromoreno
approved these changes
Jan 9, 2020
| @@ -116,12 +113,14 @@ object EvaluatorServer extends IOApp { | |||
| lazy val port = (Option(System.getenv("PORT")) orElse | |||
| Option(System.getProperty("http.port"))).map(_.toInt).getOrElse(8080) | |||
|
|
|||
| lazy val evaluator = new Evaluator[IO](15 seconds) | |||
There was a problem hiding this comment.
Out of curiosity, why did we change from 20 seconds to 15 seconds?
There was a problem hiding this comment.
Oops, should be 20? Or 15 secs is fine?
There was a problem hiding this comment.
15 should be fine, but ideally, this should be on the application.conf file
kiroco12
force-pushed
the
enrique-0-5-0-memory-fix
branch
from
df08b13
to
b9551ed
Compare
juanpedromoreno
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pretend to fix scala-exercises/scala-exercises#713 .
The actual version of evaluator is crashing when is being used, this can be a bad memory management in the evaluation process. Still trying to discover the source of the problem.