Load libraries logos from content libraries #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2016 11:53
…n internal asset in the project
This was referenced Sep 7, 2016
Current coverage is 29.28% (diff: 12.50%)@@ master #588 diff @@
==========================================
Files 50 50
Lines 1129 1137 +8
Methods 998 1009 +11
Messages 0 0
Branches 35 32 -3
==========================================
+ Hits 332 333 +1
- Misses 797 804 +7
Partials 0 0
|
|
Just added a default logo for those libraries which don't include one |
|
|
||
| def logoData(path: String): Option[String] = | ||
| Option(getClass().getClassLoader.getResourceAsStream(path)) | ||
| .map(stream ⇒ new BASE64Encoder().encode(IOUtils.toByteArray(stream))) |
There was a problem hiding this comment.
Maybe we could create a single instance of BASE64Encoder in this ExercisesService object that we could re-use each time.
|
Minor comment. Once addressed, LGTM! |
jdesiloniz
deleted the
js-520-set-library-logo-directly-in-content-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: pending default logo as being discussed in #520
This PR includes code to load the content libraries logo from the libraries themselves (instead of relying on having the logo in the scala-exercises repository). This will make it easier to content providers, as only PRs from their repositories will be needed.
Fixes: #520
Could you please review, @dialelo @raulraja @juanpedromoreno