Merge pull request #966 from Kwestor/refactor/better-error-message-on…

…-scu-cast Better error message in case of SCU cast failure
scala-ide · Jun 1, 2015 · e773514 · e773514
2 parents b0eadb1 + 8cc182c
commit e773514
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 5 deletions.
diff --git a/org.scala-ide.sdt.core/src/org/scalaide/core/internal/ScalaPlugin.scala b/org.scala-ide.sdt.core/src/org/scalaide/core/internal/ScalaPlugin.scala
@@ -129,7 +129,7 @@ class ScalaPlugin extends IScalaPlugin with PluginLogConfigurator with IResource
   private val projects = new mutable.HashMap[IProject, ScalaProject]
 
   override def scalaCompilationUnit(input: IEditorInput): Option[ScalaCompilationUnit] = {
-    def unitOfSourceFile = Option(documentProvider.getWorkingCopy(input).asInstanceOf[ScalaCompilationUnit])
+    def unitOfSourceFile = Option(documentProvider.getWorkingCopy(input)) map (ScalaCompilationUnit.castFrom)
 
     def unitOfClassFile = input.getAdapter(classOf[IClassFile]) match {
       case tr: ScalaClassFile => Some(tr)

diff --git a/org.scala-ide.sdt.core/src/org/scalaide/core/internal/jdt/model/ScalaCompilationUnit.scala b/org.scala-ide.sdt.core/src/org/scalaide/core/internal/jdt/model/ScalaCompilationUnit.scala
@@ -59,6 +59,24 @@ import org.scalaide.core.compiler.ISourceMap
 import org.eclipse.jdt.internal.corext.fix.LinkedProposalPositionGroup.PositionInformation
 import org.scalaide.core.compiler.IPositionInformation
 
+object ScalaCompilationUnit extends HasLogger {
+
+  // This method is overloaded cause we have casts from 2 unrelated types in our codebase.
+  def castFrom(icu: InteractiveCompilationUnit): ScalaCompilationUnit = cast(icu)
+  def castFrom(tr: ITypeRoot): ScalaCompilationUnit = cast(tr)
+
+  // This method provides better error message if cast fails
+  private def cast(a: AnyRef): ScalaCompilationUnit = a match {
+    case scu: ScalaCompilationUnit => scu
+    case other =>
+      val message = """Underlying compilation unit is not a Scala Compilation unit.
+                      |This is most probably caused by disabled JDT weaving.
+                      |Run `Scala -> Run Setup Diagnostics` to enable it.""".stripMargin
+      logger.error(message)
+      throw new RuntimeException(message)
+  }
+}
+
 trait ScalaCompilationUnit extends Openable
   with env.ICompilationUnit
   with ScalaElement

diff --git a/...dt.core/src/org/scalaide/ui/internal/actions/hyperlinks/HyperlinkOpenActionStrategy.scala b/...dt.core/src/org/scalaide/ui/internal/actions/hyperlinks/HyperlinkOpenActionStrategy.scala
@@ -20,7 +20,7 @@ trait HyperlinkOpenActionStrategy {
 
   private def withScalaCompilatioUnit[T](editor: JavaEditor)(f: ScalaCompilationUnit => T): Option[T] = {
     val inputJavaElement = EditorUtility.getEditorInputJavaElement(editor, false)
-    Option(inputJavaElement) map (_.asInstanceOf[ScalaCompilationUnit]) map (f)
+    Option(inputJavaElement) map (ScalaCompilationUnit.castFrom) map (f)
   }
 
   protected def isEnabled(editor: JavaEditor): Boolean = getTextSelection(editor) map { textSelection =>

diff --git a/org.scala-ide.sdt.core/src/org/scalaide/ui/internal/editor/ScalaClassFileEditor.scala b/org.scala-ide.sdt.core/src/org/scalaide/ui/internal/editor/ScalaClassFileEditor.scala
@@ -45,8 +45,8 @@ class ScalaClassFileEditor extends ClassFileEditor with ScalaCompilationUnitEdit
     super.createActions()
     val openAction = new Action {
       override def run: Unit = {
-        Option(getInputJavaElement) map (_.asInstanceOf[ScalaCompilationUnit]) foreach { scu =>
-         scu.followDeclaration(ScalaClassFileEditor.this, getSelectionProvider.getSelection.asInstanceOf[ITextSelection])
+        Option(getInputJavaElement) map (ScalaCompilationUnit.castFrom) foreach { scu =>
+          scu.followDeclaration(ScalaClassFileEditor.this, getSelectionProvider.getSelection.asInstanceOf[ITextSelection])
         }
       }
     }

diff --git a/org.scala-ide.sdt.core/src/org/scalaide/ui/internal/editor/ScalaSourceFileEditor.scala b/org.scala-ide.sdt.core/src/org/scalaide/ui/internal/editor/ScalaSourceFileEditor.scala
@@ -131,7 +131,7 @@ class ScalaSourceFileEditor
 
     val openAction = new Action {
       private def scalaCompilationUnit: Option[ScalaCompilationUnit] =
-        Option(getInteractiveCompilationUnit) map (_.asInstanceOf[ScalaCompilationUnit])
+        Option(getInteractiveCompilationUnit) map (ScalaCompilationUnit.castFrom)
 
       override def run(): Unit = {
         scalaCompilationUnit foreach { scu =>