Sort type completions differently #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small change makes it more comfortable to run the build script with
additional Maven options. To do so, simply call the script like
$ ADDITIONAL_MVN_OPTS="-DskipTests -U" ./build-all.sh
This limit makes sense because template proposals normally get a relevance of 90. Internally the relevance is calculated on a scale of 0 to 1000 though, to be more flexible. Fix #1002686
|
Test PASSed. |
| MVN_ARGS="-Pscala-2.11.x -Peclipse-luna clean install" | ||
| MVN_P2_ARGS="-Dtycho.localArtifacts=ignore -Pscala-2.11.x -Peclipse-luna clean verify" | ||
| MVN_ARGS="-Pscala-2.11.x -Peclipse-mars $ADDITIONAL_MVN_OPTS clean install" | ||
| MVN_P2_ARGS="-Dtycho.localArtifacts=ignore -Pscala-2.11.x -Peclipse-mars $ADDITIONAL_MVN_OPTS clean verify" |
There was a problem hiding this comment.
haha I was wonder who first loses his patience to add it. The previous solution impelled to write all options from scratch I guess
There was a problem hiding this comment.
Instead of the env varible you could just pass "$@" at the end, that would forward all parameters from build-all.sh to maven.
|
Cool stuff, LGTM |
|
Test PASSed. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problems explained in detail in #1002686. Note we might want to expose
ProposalRelevanceCfgin the GUI so that users can tweak it individually in future versions. At the moment a hardcoded default configuration is used.