Update to Eclipse 4.7.0 (Oxygen) #1170
Conversation
Eclipse 4.7M5 deprecated IProjectDescription#setDynamicReferences(IProject[]) and introduced dynamicReference parameter to org.eclipse.core.resources.builders extension point JDT internal implementation of IDynamicProjectReferences implementation is reused here.
Earlier, `Resource.delete(boolean force, IProgressMonitor monitor)` called `done()` on the provided monitor, but it no longer does. Hence, the actual monitor needs to be passed to `IWorkspace.run(IWorkspaceRunnable action, IProgressMonitor monitor)` in order to be terminated properly. Previous implementation of `SDTTestUtils.deleteProjects(projects: IScalaProject*)(implicit progressMonitor: IProgressMonitor)` called `IWorkspace.run(IWorkspaceRunnable action, IProgressMonitor monitor)` with a fresh `NullProgressMonitor` and passed it's `progressMonitor` to `IProject.delete(boolean: force, IProgressMonitor monitor) only.
Without this change expression evaluator tests crash with an OOM on Eclipse Oxygen.
|
Thank you for this! |
|
What's the status here? Scala 2.12.3 will soon be released, would be nice to get on the latest Scala and Eclipse releases -- that will give contributors a common base to work from moving forward. I've got a PR in the works that integrates latest Scalariform release into Eclipse Neon, but would prefer to adapt changes to scala-ide master branch after this PR gets merged in (hopefully soon). |
|
Can we get an ETA? |
|
According to what @wpopielarski said on gitter yesterday, next release for Neon can be expected before end of August and then for Oxygen mid-September. If you are interested in doing some pre-relase testing, follow Scala IDE on Eclipse Oxygen preview thread. |
|
@wpopielarski I tested this on the latest master and everything works fine. Are you ready to update to Eclipse Oxygen? I'm going to merge this then and remove support for Neon. |
|
I would merge zinc and your warnings fix change first and oxygen on it. just to be safe. |
|
@wpopielarski I'm not sure I understand. Should I rebase this branch on |
|
exactly, Simon said that it is working ok, so I don't see the reason why
this guy needs to wait for separate release.
2017-08-28 11:28 GMT+02:00 Rafał Krzewski <notifications@github.com>:
… @wpopielarski <https://github.com/wpopielarski> I'm not sure I
understand. Should I rebase this branch on master once you merge #1177
<#1177> and #1178
<#1178>? Just let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1170 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALEzS5ltMquUJPu_l8K3XzGV5M9JIwX5ks5scogzgaJpZM4ORybn>
.
|
|
All right, I'll do that. |
|
FYI, I've run the build on 3495767 with #1178 and #1170 merged in, all tests are passing and IDE works fine on my projects (up-to-date binaries are at https://storage.googleapis.com/scalaide_4_6_oxygen/site/). |
|
cool!
2017-08-28 23:50 GMT+02:00 Rafał Krzewski <notifications@github.com>:
… FYI, I've run the build on 3495767
<3495767>
with #1178 <#1178> and #1170
<#1170> merged in, all tests
are passing and IDE works fine on my projects (up-to-date binaries are at
https://storage.googleapis.com/scalaide_4_6_oxygen/site/).
I think we are good to go :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1170 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALEzS58dEASAS3ipg4KHcbGjH4mkpt_lks5sczYMgaJpZM4ORybn>
.
|
|
👍 |
Please note that Oxygen introduced binary incompatible changes. If this PR is merged as is to master, new versions of Scala IDE plugins will no longer work on Eclipse Neon and lower. Please let me know if this OK, or
platfom/oxygenshould stay as a separate branch for another Eclipse release cycle, or do we need a workaround for single sourcing the IDE for Neon and Oxygen.