Handle invalid target packages in the Move participant. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the target package of a move refactoring cannot be found (e.g. because the target is not a source folder), we abort with a warning. The user can then still move the file, but he will be warned that the source won't be changed. The JDT doesn't warn the user but simply moves the file without refactorings its content.
|
LGTM |
misto
added a commit
that referenced
this pull request
Jun 15, 2012
…01044 Handle invalid target packages in the Move participant.
Kwestor
pushed a commit
to Kwestor/scala-ide
that referenced
this pull request
Apr 22, 2015
…e:methods-from-objects-as-functions to firefly-PR-02-23 # By Piotr Kukiełka # Via Piotr Kukiełka * commit '6c4758081406d99719575669035c28d62c83c801': Add support for using methods from objects as first class functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the target package of a move refactoring cannot be found (e.g. because
the target is not a source folder), we abort with a warning. The user can
then still move the file, but he will be warned that the source won't be
changed. The JDT doesn't warn the user but simply moves the file without
refactorings its content.
See #1001044