Use textual instead of Java search to find files to index. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a Java search for files that need to be included in the refactoring index, we use a simple textual search. The problem with the Java search was that it didn't find all occurrences of a term, e.g. when a file contained only an import of a type, it wasn't found by the Java search and thus not indexed and consequently not part of the rename refactoring. Fixes #1001117
|
Started jenkins job pr-validator-master-2.9.x at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/46/ |
|
Started jenkins job pr-validator-master-trunk at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/27/ |
|
jenkins job pr-validator-master-2.9.x: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/46/ |
|
jenkins job pr-validator-master-trunk: Failed - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/27/ |
|
LGTM (the trunk build is a spurious failure). |
misto
added a commit
that referenced
this pull request
Jul 3, 2012
…-1001117 Use textual instead of Java search to find files to index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a Java search for files that need to be included
in the refactoring index, we use a simple textual search. The problem
with the Java search was that it didn't find all occurrences of a term,
e.g. when a file contained only an import of a type, it wasn't found
by the Java search and thus not indexed and consequently not part of
the rename refactoring.
Fixes #1001117