Use textual instead of Java search to find files to index. #136

Merged
merged 1 commit into from Jul 3, 2012

Projects

None yet

3 participants

@misto
Member
misto commented Jul 1, 2012

Instead of using a Java search for files that need to be included
in the refactoring index, we use a simple textual search. The problem
with the Java search was that it didn't find all occurrences of a term,
e.g. when a file contained only an import of a type, it wasn't found
by the Java search and thus not indexed and consequently not part of
the rename refactoring.

Fixes #1001117

@misto misto Use textual instead of Java search to find files to index.
Instead of using a Java search for files that need to be included
in the refactoring index, we use a simple textual search. The problem
with the Java search was that it didn't find all occurrences of a term,
e.g. when a file contained only an import of a type, it wasn't found
by the Java search and thus not indexed and consequently not part of
the rename refactoring.

Fixes #1001117
4557886
@scala-jenkins
Collaborator

Started jenkins job pr-validator-master-2.9.x at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/46/

@scala-jenkins
Collaborator

Started jenkins job pr-validator-master-trunk at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/27/

@scala-jenkins
Collaborator

jenkins job pr-validator-master-2.9.x: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/46/

@scala-jenkins
Collaborator
@dragos
Member
dragos commented Jul 2, 2012

LGTM (the trunk build is a spurious failure).

@misto misto merged commit 654074c into scala-ide:master Jul 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment