Adds anon function and flags in cache #296
Conversation
Creates an new map cache to store information about method containing the code of anonymous functions, and method flags. With tests. Fixes #1001001
|
Started jenkins job pr-validator-master-trunk at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/351/ |
|
Started jenkins job pr-validator-master-2.9.x at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/358/ |
|
jenkins job pr-validator-master-2.9.x: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/358/ |
|
jenkins job pr-validator-master-trunk: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/351/ |
|
Very neat! No comment (LGTM). |
| import com.sun.jdi.Location | ||
| import com.sun.jdi.Method | ||
| import com.sun.jdi.ReferenceType | ||
| import com.sun.jdi.event.ClassPrepareEvent | ||
|
|
||
| object ScalaDebugCache { |
There was a problem hiding this comment.
Is it possible to start two different debug sessions within Eclipse (e.g., for two different projects). If yes, then the cache would be shared.
There was a problem hiding this comment.
I don't understand your question.
This is just a companion object, with some constants, some simple functions, and an apply() method to create cache instances.
The cache should not be shared between debug sessions. It contains JDI elements, which are direct references of internal structures of the debugged VM. They have to be used with the VM which provided them.
There was a problem hiding this comment.
The git-diff fooled me. I see now the typeCache is not part of the module. It's all good then.
|
LGTM. |
…s-1001001 Adds anon function and flags in cache
Creates an new map cache to store information about method containing the code
of anonymous functions, and method flags.
With tests.
The cache is using 'simple' synchronization. It is not possible to put it inside the cache actor as it would create re-entrant synchronized actor calls.
Fixes #1001001