Use Scala specific task markers. #330
Conversation
Don't use Java task markers for Scala sources, as the Java builder removes them all on "full build", which is what we trigger from the Sbt build manager if: * Java sources need recompilation * resources (non-source files) exist on the source path (so they are copied to the output folder) This commit adds a Scala specific marker type (subtype of the Java one) that preserves all functionality, but is only handled by our code. Fixed #1001401, #1000975.
|
Started jenkins job pr-validator-master-trunk at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/435/ |
|
Started jenkins job pr-validator-master-2.9.x at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/443/ |
|
jenkins job pr-validator-master-2.9.x: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/443/ |
|
LGTM One thing though, FileUtils seems to contain a lot of unused imports. I would be great if you could clean it up. |
|
jenkins job pr-validator-master-trunk: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/435/ |
|
Pushed another commit with organized imports. |
|
Sweet. And still good for me. |
|
Started jenkins job pr-validator-master-trunk at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/436/ |
|
Started jenkins job pr-validator-master-2.9.x at https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/444/ |
|
jenkins job pr-validator-master-2.9.x: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-2.9.x/444/ |
|
jenkins job pr-validator-master-trunk: Success - https://jenkins.scala-ide.org:8496/jenkins/job/pr-validator-master-trunk/436/ |
|
Still waiting for a second pair of 👀 |
|
The patch looks good. Only comment I have is that we seem not to protect ourselves against "too big comments" that can cause assertion failures, see https://github.com/dragos/scala-ide/blob/907342a8655695fa59936689154eb63ac3a2b296/org.scala-ide.sdt.core/src/scala/tools/eclipse/resources/MarkerFactory.scala#L62 |
|
That's a good observation, but |
Use Scala specific task markers.
Use Scala specific task markers.(cherry picked from commit f248290)
|
Cherry-picked and pushed to 3.0.x (cherry-picked the merge commit, to test the changelog tool). |
Don't use Java task markers for Scala sources, as the Java builder
removes them all on "full build", which is what we trigger from the
Sbt build manager if:
copied to the output folder)
This commit adds a Scala specific marker type (subtype of the Java one)
that preserves all functionality, but is only handled by our code.
Fixed #1001401, #1000975.