Backport/semantic highlighting on classfiles #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a `ScalaCompilationUnitEditor` that contains the logic common to both the `ScalaSourceFileEditor` and the `ScalaClassFileEditor`. In particular, the logic needed to install/dispose semantic highlighting is encapsulated in `ScalaCompilationUnitEditor`. It is worth pointing out that the initialization of the Semantic Highlighting engine is different for the two editors. On the one hand, on an editable scala source, semantic highlighting is triggered by the reconciler. On the other hand, for a classfile source attachement, no reconciler is needed (because the source file can't be edited), hence semantic highlighting needs to be forced at initialization. This is why in `ScalaCompilationUnitEditor` we have the following two additional abstract methods * `forceSemanticHighlightingOnInstallment` * `createSemantichHighlighter` This commit comes with no tests because it is not possible to avoid the loading of UI classes. Fix #1000939 (cherry picked from commit cb87dc5) Conflicts: org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaClassFileEditor.scala org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaSourceFileEditor.scala org.scala-ide.sdt.core/src/scala/tools/eclipse/semantichighlighting/ui/TextPresentationEditorHighlighter.scala org.scala-ide.sdt.core/src/scala/tools/eclipse/semicolon/ShowInferredSemicolonsAction.scala
|
I've monkey tested this and it seemed to work fine. |
|
Test FAILed. |
|
failure is expected... |
|
Test FAILed. |
|
Maybe we want to push this on 3.0.x-juno first, so that validation works ? |
|
@huitseeker I can open a mirror PR for this on juno. |
|
Compiled and smoked tested this PR locally. |
dotta
added a commit
that referenced
this pull request
Sep 3, 2013
…classfiles Backport/semantic highlighting on classfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.