Quick fix exceptions #863
Merged
Quick fix exceptions #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2014 15:12
As it will return 'null', if there are no spelling mistake to fix.
SafeRunner already log the stack trace. Tweaked the error message to point to this stack trace.
|
Test PASSed. See Console Output in the link below for an update site containing this PR binary artefacts. Refer to this link for build results: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-ide-validator/1303/ |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit wraps the return value of
WordQuickFixProcessor.getCorrectionsin a Option, as it can return 'null'.The second one tweaks the call to SafeRunner to avoid to have a duplicate stack trace in case of problem.
The original goal was to fix tickets 1002317 and 1002281, but the real problem lies between Scala compiler and Scala refactoring (scala-ide/scala-refactoring#67).