Fix compiler warning #941
Fix compiler warning #941
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -131,6 +131,7 @@ class MoveClass extends RefactoringExecutorWithWizard { | |||
| (change :: textChanges, newFiles) | |||
| case (change: NewFileChange, (textChanges, newFilesChanges)) => | |||
| (textChanges, change :: newFilesChanges) | |||
| case (other, _) => throw new AssertionError(s"Unexpected change $other") | |||
There was a problem hiding this comment.
Please improve the message in a way that it explains that only TextChange and NewFileChange make sense here.
There was a problem hiding this comment.
I don't see any difference between throwing MatchError and AssertionError. Actually, as @sschaef noticed, MatchError gives you more information. I understand the warning is gone, but then let's report the error in a better way. (or use @unchecked to silence the warning).
Fixes #1002444
mlangc
force-pushed
the
compiler-warning-in-move-class-1002444
branch
from
e5cff9f
to
ef17feb
Compare
|
Hmm, you have a point. Please tell me if you like the new message better; if not I'd go for the |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM |
Fixes #1002444