Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Refactorings might mess with parens #94

Commits on Sep 6, 2015

  1. Configuration menu
    Copy the full SHA
    a67e7b8 View commit details
    Browse the repository at this point in the history
  2. Refactoring

    mlangc committed Sep 6, 2015
    Configuration menu
    Copy the full SHA
    f400d6e View commit details
    Browse the repository at this point in the history
  3. Handle braces in string constants properly

    Prior versions of `CommonPrintUtils.balanceParens` treated parens in string
    constants just like parens in regular Scala code which resulted in bugs like
    ticket #1002088. This commit improves the aforementioned function, that also
    played a prominent role in ticket #1002166, by delegating counting parens
    to a helper function, that handles comments and string constants properly.
    
    Fixes #1002088
    mlangc committed Sep 6, 2015
    Configuration menu
    Copy the full SHA
    01649d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3f8901c View commit details
    Browse the repository at this point in the history
  5. Rename balanceParens to balanceBrackets

    The term "brackets" is used for "<>", "()", "{}" and "[]", while parens usually
    refers to "()" and "{}" only. As the function in question accepts the brackets
    as parameters, "brackets" is more appropriate than "parens".
    mlangc committed Sep 6, 2015
    Configuration menu
    Copy the full SHA
    88e7333 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2015

  1. Configuration menu
    Copy the full SHA
    d596269 View commit details
    Browse the repository at this point in the history
  2. Remove code that seems to have no functionality

    `CommonPrintUtils.balanceBrackets` used to contain some code that was meant to
    add missing closing brackets directly after the last closing bracket, instead of
    just appending them to the layout. Given the fact that the code was broken anyway,
    (it didn't consider comments, string constants, etc.), all tests pass without it,
    and the original author thinks that it's not needed, it seems safe to remove it.
    mlangc committed Sep 7, 2015
    Configuration menu
    Copy the full SHA
    6279d92 View commit details
    Browse the repository at this point in the history