Fix type of CustomEvent detail attribute #271
Conversation
| @@ -5091,7 +5091,7 @@ class CustomEvent extends Event { | |||
| * | |||
| * MDN | |||
| */ | |||
| def detail: Object = js.native | |||
| def detail: js.Any = js.native | |||
There was a problem hiding this comment.
It should be Any then, not js.Any.
There was a problem hiding this comment.
Hm. I guess I assumed it should be js.Any since it seemed to be consistent with most other similar attributes/methods. For example, the History API has the following:
def state: js.Any = js.native
def pushState(statedata: js.Any, title: String): Unit = js.native
There only seem to be a handful of uses of java.lang.Object, but now that I look more closely, there are quite a few uses of scala.Any. There are even a few cases that are not consistent within the same class, for example MessageEvent. This uses scala.Any for the data attribute but js.Any for the corresponding argument to initMessageEvent.
I'm not sure I understand why all these would be slighly different. Is it just an artifact of having imported them from the TypeScript type definitions? I'm happy to make the change you requested, of course, just thought I would clarify first.
There was a problem hiding this comment.
Most js.Anys are artifacts of importing from TypeScript, and should be Any.
| @@ -5100,7 +5100,7 @@ class CustomEvent extends Event { | |||
| * MDN | |||
| */ | |||
| def initCustomEvent(typeArg: String, canBubbleArg: Boolean, | |||
| cancelableArg: Boolean, detailArg: Object): Unit = js.native | |||
| cancelableArg: Boolean, detailArg: js.Any): Unit = js.native | |||
andersschuller
force-pushed
the
fix-custom-event-detail
branch
from
e7f3ac5
to
4990736
Compare
|
OK, commit amended with the requested changes. |
See https://dom.spec.whatwg.org/#interface-customevent