Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.0.0-SNAPSHOT. #452

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Bump to 2.0.0-SNAPSHOT. #452

merged 1 commit into from
Aug 4, 2021

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jul 14, 2021

So that we can release v2.0.0 with the Scala 3 artifact.

Fixes #451.

So that we can release v2.0.0 with the Scala 3 artifact.

Fixes scala-js#451.
@sjrd sjrd requested a review from gzm0 July 14, 2021 14:57
@gzm0
Copy link
Contributor

gzm0 commented Jul 14, 2021

I have commented on #451 regarding this.

@gzm0
Copy link
Contributor

gzm0 commented Jul 15, 2021

So, I'm still unsure about what the community consensus is regarding that. But the major bump in itself is correct. So I'm going to approve this.

@sjrd if you want my opinion on what to do with regards to this, I'll need significantly more time, because I need to learn how the entire dotty compat thing is supposed to work and how it works in practice. I'm not able to follow the conversation in #451.

@sjrd
Copy link
Member Author

sjrd commented Aug 4, 2021

Given the reactions at #451 (comment), I'm going to merge this, and proceed with a bunch of cleanups.

@sjrd sjrd merged commit e695bca into scala-js:master Aug 4, 2021
@sjrd sjrd deleted the towards-2.0.0 branch August 4, 2021 08:07
@armanbilge
Copy link
Member

armanbilge commented Aug 4, 2021

@sjrd Thanks for going forward with this! :) Can I help with any/all of the cleanup tasks? I ask, just to make sure that there aren't any duplicate efforts.

@sjrd
Copy link
Member Author

sjrd commented Aug 4, 2021

I have started doing the cleanups today. If I have to move to other things, I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What to do about the Scala 3-specific artifact?
3 participants