Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation shows package object extending js.GlobalScope without @js.native #203

Closed
mseddon opened this issue Nov 28, 2015 · 1 comment

Comments

@mseddon
Copy link
Contributor

mseddon commented Nov 28, 2015

Found by @bblfish here:

scala-js/scala-js-dom#177 (comment)

On this page:

http://www.scala-js.org/doc/interoperability/facade-types.html

There is a snippet of the documentation which shows a package object extending js.GlobalScope, but these will not compile because it lacks @js.native annotations.

@bblfish
Copy link

bblfish commented Nov 28, 2015

It will compile actually if the -Xfatal-warnings is not set. But in any case it seems to be deprecated, so that the example in the documenation should remove the package object example, and explain instead the preferred method explained by sjrd in issue 177

@sjrd sjrd closed this as completed in 3f0ccde Jan 11, 2016
sjrd added a commit that referenced this issue Jan 11, 2016
Fix #203: Remove the js.GlobalScope package object example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants