Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProvidedJS requires OS dependent path separator #2358

Closed
rpiaggio opened this issue Apr 26, 2016 · 4 comments
Closed

ProvidedJS requires OS dependent path separator #2358

rpiaggio opened this issue Apr 26, 2016 · 4 comments
Assignees
Labels
bug Confirmed bug. Needs to be fixed.
Milestone

Comments

@rpiaggio
Copy link

In order to include src/main/resources/js/dependency.js on a build that is ran in Windows, we have to specify ProvidedJS / "js\\dependency.js".

ProvidedJS / "js/dependency.js" does not work. It results in the following error:

> show resolvedJSDependencies
[trace] Stack trace suppressed: run last compile:resolvedJSDependencies for the full output.
[error] (compile:resolvedJSDependencies) org.scalajs.core.tools.jsdep.JSLibResolveException: Some references to JS libraries could not be resolved:
[error] - Missing JS library: js/dependency.js

since the String returned by FileVirtualJSFile.relativePath contains a backslash.

@sjrd
Copy link
Member

sjrd commented Apr 26, 2016

Thanks for the report!

@sjrd sjrd added the bug Confirmed bug. Needs to be fixed. label Apr 26, 2016
@sjrd sjrd added this to the v0.6.9 milestone Apr 26, 2016
@sjrd
Copy link
Member

sjrd commented Apr 26, 2016

I am pretty sure that this line is responsible. We should normalize relPath to always using /. I'll do that when I'm on a Windows machine, hopefully tonight.

@sjrd sjrd self-assigned this Apr 26, 2016
@rpiaggio
Copy link
Author

Thank you very much for the fix! Is there an expected release date for 0.6.9?

@sjrd sjrd closed this as completed in 685e084 Apr 27, 2016
sjrd added a commit that referenced this issue Apr 27, 2016
Fix #2358: Normalize the dir separator to '/' in relative paths.
@sjrd
Copy link
Member

sjrd commented Apr 27, 2016

This week.

@sjrd sjrd removed the has-pr label Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug. Needs to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants