Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error to outlaw user-space use of RawJSType #2387

Closed
sjrd opened this issue May 11, 2016 · 3 comments
Closed

Compile error to outlaw user-space use of RawJSType #2387

sjrd opened this issue May 11, 2016 · 3 comments
Assignees
@nicolasstucki
Labels
bug Confirmed bug. Needs to be fixed.
Milestone
v0.6.10

Comments

@sjrd
Copy link
Member

sjrd commented May 11, 2016

The compiler should prevent developers from using @RawJSType (and other compiler-inserted annotations).
@sjrd sjrd added the bug Confirmed bug. Needs to be fixed. label May 11, 2016
@sjrd sjrd added this to the v0.6.10 milestone May 11, 2016
@sjrd
Copy link
Member Author

sjrd commented May 11, 2016

/cc @katrinsharp :-p

@gzm0
Copy link
Contributor

gzm0 commented May 11, 2016

Hahahaha, Katrin, you did not seriously use this??

@katrinsharp
Copy link

I used it big time, ask Sebastian :) Now seriously speaking when I accidentally stumbled upon this thing yesterday I thought that 'RawJSType' is a new replacement for 'ScalaJSDefined' and I actually liked the name :) cc @gzm0

@nicolasstucki nicolasstucki self-assigned this May 12, 2016
nicolasstucki added a commit to nicolasstucki/scala-js that referenced this issue May 12, 2016
@nicolasstucki
Fix scala-js#2387: Emit compile error for compiler annotations.
5a91d0a
nicolasstucki added a commit to nicolasstucki/scala-js that referenced this issue May 17, 2016
@nicolasstucki
Fix scala-js#2387: Emit compile error for compiler annotations.
362b000
nicolasstucki added a commit to nicolasstucki/scala-js that referenced this issue May 18, 2016
@nicolasstucki
Fix scala-js#2387: Emit compile error for compiler annotations.
5b7563b
nicolasstucki added a commit to nicolasstucki/scala-js that referenced this issue May 18, 2016
@nicolasstucki
Fix scala-js#2387: Emit compile error for compiler annotations.
7644094
@sjrd sjrd closed this as completed in cad146d May 19, 2016
sjrd added a commit that referenced this issue May 19, 2016
@sjrd
Merge pull request #2388 from nicolasstucki/warn-compiler-annotations
0c9952f 
Fix #2387: Emit compile error for compiler annotations.
@sjrd sjrd removed the has-pr label Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolasstucki nicolasstucki

Labels
bug Confirmed bug. Needs to be fixed.
Projects
None yet
Milestone
v0.6.10
Development

No branches or pull requests
4 participants
@sjrd @gzm0 @katrinsharp @nicolasstucki