Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that buffered com messages are not sent immediately upon init #3411

Closed
gzm0 opened this issue Jul 21, 2018 · 0 comments
Closed

Ensure that buffered com messages are not sent immediately upon init #3411

gzm0 opened this issue Jul 21, 2018 · 0 comments
Assignees
@gzm0
Labels
enhancement Feature request (that does not concern language semantics, see "language")
Milestone
v1.0.0-M6

Comments

@gzm0
Copy link
Contributor

gzm0 commented Jul 21, 2018

The ExternalJSEnv needs to fix this and the test suite needs to verify it.
@gzm0 gzm0 added the enhancement Feature request (that does not concern language semantics, see "language") label Jul 21, 2018
@gzm0 gzm0 modified the milestones: v1.0.0, v1.0.0-M6 Jul 21, 2018
@gzm0 gzm0 self-assigned this Jul 21, 2018
gzm0 added a commit to gzm0/scala-js that referenced this issue Jul 21, 2018
@gzm0
Fix scala-js#3411: Do not call onMessage immediately after init
125f274 
This change contains a fix to this in the Node.js Com support and a
test in the test suite for this.
gzm0 added a commit to gzm0/scala-js that referenced this issue Jul 21, 2018
@gzm0
Fix scala-js#3411: Do not call onMessage immediately after init
729368b 
This change contains a fix to this in the Node.js Com support and a
test in the test suite for this.
@gzm0 gzm0 closed this as completed in 0bf8e18 Jul 21, 2018
sjrd added a commit to sjrd/scala-js-env-jsdom-nodejs that referenced this issue Oct 20, 2018
@sjrd
Remove workarounds for upstream bugs fixed in 1.0.0-M6.
3f4ecbc 
Namely:

* scala-js/scala-js#3411
* scala-js/scala-js#3412
@sjrd sjrd mentioned this issue Oct 20, 2018
Merged
sjrd pushed a commit to sjrd/scala-js-js-envs that referenced this issue Jun 15, 2020
@gzm0
Fix scala-js/scala-js#3411: Do not call onMessage immediately after init
3a03cce 
This change contains a fix to this in the Node.js Com support and a
test in the test suite for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
enhancement Feature request (that does not concern language semantics, see "language")
Projects
None yet
Milestone
v1.0.0-M6
Development

No branches or pull requests
1 participant
@gzm0