Split TopLevelExportDefs away from LinkedClass #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Split away from #4111. To be merged now, or not :) |
sjrd
reviewed
Jul 15, 2020
| @@ -42,8 +43,6 @@ object Infos { | |||
| val methods: List[MethodInfo], | |||
| val jsNativeMembers: Map[MethodName, JSNativeLoadSpec], | |||
| val exportedMembers: List[ReachabilityInfo], | |||
There was a problem hiding this comment.
The CI says:
Suggested change
| val exportedMembers: List[ReachabilityInfo], | |
| val exportedMembers: List[ReachabilityInfo] |
gzm0
force-pushed
the
split-top-level-exports
branch
from
648910e
to
770c20b
Compare
sjrd
approved these changes
Jul 15, 2020
gzm0
force-pushed
the
split-top-level-exports
branch
from
770c20b
to
5f82662
Compare
sjrd
reviewed
Jul 16, 2020
| def loadClassDefAndVersion(irFile: IRFileImpl)( | ||
| implicit ec: ExecutionContext): Future[(ClassDef, Option[String])] = { | ||
| update(irFile).map(s => (s._1, version)) | ||
| } | ||
|
|
||
| private def update(irFile: IRFileImpl)( | ||
| implicit ec: ExecutionContext): Future[(ClassDef, Infos.ClassInfo)] = synchronized { | ||
| implicit ec: ExecutionContext): Future[(ClassDef, Infos.ClassInfo, List[Infos.TopLevelExportInfo])] = synchronized { |
There was a problem hiding this comment.
The CI says that this line is too long (more than 120 characters). Perhaps move the synchronized inside?
There was a problem hiding this comment.
I took the chance to simplify this a bit. PTAL
This will help with organizing modules. Side-effects for TopLevelMethodExportDefs in IRChecker: - Allow them on all class kinds. - Allow names containing `__` for non JS classes. - Disallow references to JS class captures (this was a bug).
gzm0
force-pushed
the
split-top-level-exports
branch
from
5f82662
to
9616e5e
Compare
sjrd
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side-effects for TopLevelMethodExportDefs in IRChecker:
__for non JS classes.