Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2681: Module Splitting Support #4198

Merged
merged 7 commits into from Oct 4, 2020
Merged

Commits on Oct 2, 2020

  1. Fix Jimfs filesystem structure in partest

    Without the leading slash, the resulting Path ends up not having a
    parent Path / directory. This in turn makes the (upcoming) backwards
    compatibility adapter for the Linker fail.
    
    While `Path`s without parents are techincally allowed, its hardly a
    case we should care about for the backwards compatibility adapter.
    gzm0 committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    16135f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d2fce0 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. Enable SAM support on the linker

    Adding -Xexperimental makes compilation fail if the unapply is not
    marked final: "could not optimize @tailrec annotated method unapply:
    it is neither private nor final so can be overridden"
    gzm0 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    fc9498c View commit details
    Browse the repository at this point in the history
  2. Add Module Splitting support in the linker

    This commit does not add support to the compiler nor the sbt-plugin to
    test backwards compatibility.
    
    Further, we do not deprecate the old API yet to avoid build failures.
    gzm0 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    1ec6471 View commit details
    Browse the repository at this point in the history
  3. Add Module Splitting support in the compiler

    We cannot test this fully yet, since we need support in the sbt-plugin
    for that.
    gzm0 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    7c2a5e1 View commit details
    Browse the repository at this point in the history
  4. Add Module Splitting support in the sbt-plugin

    At this point, we can fully test exports end-to-end. We do not migrate
    all sbt-plugin tests to test backwards compatibility. However, we can
    now deprecate the old APIs without build failures.
    
    The custom-linker sbt test is migrated in this commit because it
    relies on the internal scalaJSLinkerBox key.
    gzm0 committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    225a052 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e1e723e View commit details
    Browse the repository at this point in the history