Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up with Scala 2.13.4 #4276

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Catch up with Scala 2.13.4 #4276

merged 3 commits into from
Nov 7, 2020

Commits on Nov 5, 2020

  1. Use CharBuffer.wrap to get a CharSequence from an Array[Char].

    The implicit conversion in `Predef` was made non-implicit in Scala
    2.13.4, because of issues on JDK15+. We could explicitly call it,
    but the recommended replacement is to use `CharBuffer.wrap`.
    sjrd committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    d125987 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2020

  1. Address new warnings with the stricter patmat exhaustivity of 2.13.4.

    In 2.13.4, the pattern match exhaustivity analysis has become
    stricter. It remains active in the presence of guards and custom
    extractors (including `unapplySeq`). This change causes some new
    warnings in our codebase, which this commit addresses.
    
    See scala/scala#9140, which was somewhat
    toned down by scala/scala#9299.
    sjrd committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    592391e View commit details
    Browse the repository at this point in the history
  2. Adapt MatchASTTest for Scala 2.13.4.

    Something seems to have changed in Scala 2.13.4 that optimizes
    `match`es whose scrutinee is a literal, causing two (similar) tests
    to fail. Since the literal scrutinee was not the point of those
    tests, we move it to another `def`.
    sjrd committed Nov 7, 2020
    Configuration menu
    Copy the full SHA
    22a12c9 View commit details
    Browse the repository at this point in the history