Fix #4593: Track askers of hasElidableModuleAccessor #4594
Conversation
|
|
||
| var hasElidableModuleAccessor: Boolean = false | ||
|
|
||
| var fields: List[AnyFieldDef] = Nil | ||
| var fields: List[AnyFieldDef] = linkedClass.fields |
There was a problem hiding this comment.
The previous setupAfterCreation did not set fields. Is it intentional that, in this refactoring, we now set fields anyway? If yes, why? If not, should it stay Nil (at least in this commit)? Should it be in the next commit instead?
There was a problem hiding this comment.
I was concerned about initialization order: In this commit MethodContainer#updateWith will try to set fields during construction.
Probably I should simply invert this commit and the "update field in walkForChanges". That will be cleaner.
There was a problem hiding this comment.
That, or initialize it with = _, which will make sure that there is no initialization code in this constructor that will override what updateWith already set before.
This allows us to get rid of one of the matches on this in `updateWith`.
This does not force the caller to call an "init" method just after calling the constructor.
gzm0
force-pushed
the
elidable-module-accessor
branch
from
13acc3c
to
8cb758b
Compare
No description provided.